Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Call ApiErrorModal using Error Boundary #106

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Call ApiErrorModal using Error Boundary #106

wants to merge 1 commit into from

Conversation

jarellb
Copy link
Contributor

@jarellb jarellb commented Nov 7, 2024 •
edited
Loading

Ticket Link

Groupings-1801

List of squashed commits

  • Resolve ownedGrouping error handling jest test
  • Made handleFetch async to await sendStackTrace
  • Resolve ESLint errors
  • Switch to using global-error.tsx
  • Implement error.tsx with default home spacing

Test Checklist

  • Unit Tests Passed
  • Integration Tests Passed
  • General Visual Inspection

@jarellb jarellb force-pushed the dev-jarellab-1801 branch 3 times, most recently from 1770cf0 to 6ffca46 Compare November 8, 2024 03:08
@JorWo
Copy link
Contributor

JorWo commented Nov 8, 2024 •
edited
Loading

The ApiError modal seems to always appear due to a hydration error.

Also I'm not sure if naming a component ErrorBoundary would automatically make it catch errors.

JorWo
JorWo reviewed Nov 8, 2024
View reviewed changes
ui/src/app/layout.tsx Outdated
Comment on lines 27 to 34
<ErrorBoundary>
<main className="h-full 2xl:min-h-[72.3vh]">{children}</main>
</ErrorBoundary>
Copy link
Contributor

@JorWo JorWo Nov 8, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found it nicer to just have <ErrorBoundary /> so that the error modal displays without removing the main content.

@jarellb jarellb force-pushed the dev-jarellab-1801 branch 2 times, most recently from 6d46684 to 2aae9ea Compare November 19, 2024 05:43
@jarellb jarellb marked this pull request as draft November 20, 2024 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorWo JorWo JorWo left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jarellb @JorWo